Fixed broken driver unloading on shutdown/crash

Core/Crash/CrashHandler.cpp

@@ -670,23 +670,7 @@ namespace CrashHandler
         ExceptionOccurred = true;
 
         if (DriverManager)
-        {
+            DriverManager->UnloadAllDrivers();
-            KernelCallback callback;
-            foreach (Driver::DriverFile *drv in DriverManager->GetDrivers())
-            {
-                memset(&callback, 0, sizeof(KernelCallback));
-                callback.Reason = StopReason;
-                debug("Stopping driver %ld...", drv->DriverUID);
-                DriverManager->IOCB(drv->DriverUID, (void *)&callback);
-
-                for (size_t i = 0; i < sizeof(drv->InterruptHook) / sizeof(drv->InterruptHook[0]); i++)
-                {
-                    if (!drv->InterruptHook[i])
-                        continue;
-                    delete drv->InterruptHook[i];
-                }
-            }
-        }
 
         debug("Reading control registers...");
         crashdata.Frame = Frame;

Core/Driver/Driver.cpp

@@ -28,6 +28,26 @@ namespace Driver
         "Input",
         "Audio"};
 
+    void Driver::UnloadAllDrivers()
+    {
+        KernelCallback callback;
+        debug("%ld drivers loaded, [DUIDs: %ld]", DriverManager->GetDrivers().size(), DriverUIDs);
+        foreach (DriverFile *drv in DriverManager->GetDrivers())
+        {
+            memset(&callback, 0, sizeof(KernelCallback));
+            callback.Reason = StopReason;
+            debug("Stopping & unloading driver %ld [%#lx]", drv->DriverUID, drv->Address);
+            DriverManager->IOCB(drv->DriverUID, (void *)&callback);
+
+            for (size_t i = 0; i < sizeof(drv->InterruptHook) / sizeof(drv->InterruptHook[0]); i++)
+            {
+                if (!drv->InterruptHook[i])
+                    continue;
+                delete drv->InterruptHook[i];
+            }
+        }
+    }
+
     int Driver::IOCB(unsigned long DUID, void *KCB)
     {
         foreach (auto var in Drivers)

Core/Driver/DriverLoading/BindInput.cpp

@@ -64,7 +64,7 @@ namespace Driver
             KernelAllocator.FreePages(KCallback, TO_PAGES(sizeof(KernelCallback)));
 
             DriverFile *DrvFile = new DriverFile;
-            DrvFile->DriverUID = KAPI.Info.DriverUID;
+            DrvFile->DriverUID = this->DriverUIDs - 1;
             DrvFile->Address = (void *)fex;
             DrvFile->InterruptHook[0] = nullptr;
             Drivers.push_back(DrvFile);

Core/Driver/DriverLoading/BindInterrupt.cpp

@@ -42,7 +42,7 @@ namespace Driver
         {
             fixme("Generic driver: %s", fexExtended->Driver.Name);
             DriverFile *DrvFile = new DriverFile;
-            DrvFile->DriverUID = KAPI.Info.DriverUID;
+            DrvFile->DriverUID = this->DriverUIDs - 1;
             DrvFile->Address = (void *)fex;
             Drivers.push_back(DrvFile);
             break;
@@ -142,7 +142,7 @@ namespace Driver
             KCallback->Reason = CallbackReason::InterruptReason;
 
             DriverFile *DrvFile = new DriverFile;
-            DrvFile->DriverUID = KAPI.Info.DriverUID;
+            DrvFile->DriverUID = this->DriverUIDs - 1;
             DrvFile->Address = (void *)fex;
             DrvFile->InterruptHook[0] = InterruptHook;
             Drivers.push_back(DrvFile);

Core/Driver/DriverLoading/BindPCI.cpp

@@ -121,7 +121,7 @@ namespace Driver
                         KCallback->Reason = CallbackReason::InterruptReason;
 
                         DriverFile *DrvFile = new DriverFile;
-                        DrvFile->DriverUID = KAPI.Info.DriverUID;
+                        DrvFile->DriverUID = this->DriverUIDs - 1;
                         DrvFile->Address = (void *)fex;
                         DrvFile->InterruptHook[0] = InterruptHook;
                         Drivers.push_back(DrvFile);
@@ -150,7 +150,7 @@ namespace Driver
                         }
 
                         DriverFile *DrvFile = new DriverFile;
-                        DrvFile->DriverUID = KAPI.Info.DriverUID;
+                        DrvFile->DriverUID = this->DriverUIDs - 1;
                         DrvFile->Address = (void *)fex;
                         DrvFile->InterruptHook[0] = nullptr;
                         Drivers.push_back(DrvFile);

KThread.cpp

@@ -83,23 +83,8 @@ Exit:
 void KernelShutdownThread(bool Reboot)
 {
     if (DriverManager)
-    {
+        DriverManager->UnloadAllDrivers();
-        KernelCallback callback;
-        foreach (Driver::DriverFile *drv in DriverManager->GetDrivers())
-        {
-            memset(&callback, 0, sizeof(KernelCallback));
-            callback.Reason = StopReason;
-            debug("Stopping driver %ld...", drv->DriverUID);
-            DriverManager->IOCB(drv->DriverUID, (void *)&callback);
 
-            for (size_t i = 0; i < sizeof(drv->InterruptHook) / sizeof(drv->InterruptHook[0]); i++)
-            {
-                if (!drv->InterruptHook[i])
-                    continue;
-                delete drv->InterruptHook[i];
-            }
-        }
-    }
     trace("Shutting Down/Rebooting...");
     if (Reboot)
         PowerManager->Reboot();

include/driver.hpp

@@ -63,6 +63,7 @@ namespace Driver
 
     public:
         Vector<DriverFile *> GetDrivers() { return Drivers; }
+        void UnloadAllDrivers();
         int IOCB(unsigned long DUID, /* KernelCallback */ void *KCB);
         DriverCode LoadDriver(uint64_t DriverAddress, uint64_t Size);
         DriverCode StartDrivers();