Fix bug causing vector removal to skip elements

Core/Driver/Driver.cpp

@@ -83,8 +83,8 @@ namespace Driver
             }
             if (drv.MemTrk)
                 delete drv.MemTrk, drv.MemTrk = nullptr;
-            Drivers.remove(drv);
         }
+        Drivers.clear();
     }
 
     bool Driver::UnloadDriver(unsigned long DUID)
@@ -268,7 +268,10 @@ namespace Driver
     {
         SmartLock(DriverInterruptLock); /* Lock in case of multiple interrupts firing at the same time */
         if (!this->Enabled)
+        {
+            debug("Interrupt hook is not enabled");
             return;
+        }
 
         if (!Handle.InterruptCallback)
         {

Core/InterruptsManager.cpp

@@ -131,6 +131,7 @@ namespace Interrupts
     {
 #if defined(a64)
         CPU::x64::TrapFrame *Frame = (CPU::x64::TrapFrame *)Data;
+        // debug("IRQ%ld", Frame->InterruptNumber - 32);
 
         memmove(InterruptFrames + 1, InterruptFrames, sizeof(InterruptFrames) - sizeof(InterruptFrames[0]));
         InterruptFrames[0] = (void *)Frame->rip;

Core/Random.cpp

@@ -43,6 +43,8 @@ namespace Random
                     RDRANDFlag = cpuid.ECX.RDRAND;
                 }
             }
+            else
+                RDRANDFlag = 0;
         }
 
         if (RDRANDFlag)
@@ -80,6 +82,8 @@ namespace Random
                     RDRANDFlag = cpuid.ECX.RDRAND;
                 }
             }
+            else
+                RDRANDFlag = 0;
         }
 
         if (RDRANDFlag)
@@ -117,6 +121,8 @@ namespace Random
                     RDRANDFlag = cpuid.ECX.RDRAND;
                 }
             }
+            else
+                RDRANDFlag = 0;
         }
 
         if (RDRANDFlag)

Core/UniversalAsynchronousReceiverTransmitter.cpp

@@ -161,7 +161,7 @@ namespace UniversalAsynchronousReceiverTransmitter
 
     SafeFunction NIF Events::~Events()
     {
-        for (uintptr_t i = 0; i < RegisteredEvents.size(); i++)
+        for (size_t i = 0; i < RegisteredEvents.size(); i++)
             if (RegisteredEvents[i] == this)
             {
                 RegisteredEvents.remove(i);

GUI/GraphicalUserInterface.cpp

@@ -660,7 +660,6 @@ namespace GraphicalUserInterface
         delete this->OverlayBuffer, this->OverlayBuffer = nullptr;
         delete this->CursorBuffer, this->CursorBuffer = nullptr;
         Display->DeleteBuffer(200);
-        for (size_t i = 0; i < this->Windows.size(); i++)
-            this->Windows.remove(i);
+        this->Windows.clear();
     }
 }

Network/AddressResolutionProtocol.cpp

@@ -49,6 +49,7 @@ namespace NetworkARP
                     netdbg("Removed %s from discovered addresses", IP.v4.ToStringLittleEndian());
                     delete tmp, tmp = nullptr;
                     DiscoveredAddresses.remove(i);
+                    break;
                 }
             }
             return nullptr;

Network/NetworkController.cpp

@@ -59,8 +59,7 @@ namespace NetworkInterfaceManager
         this->StopNetworkStack();
 
         // Unregister all events
-        for (size_t i = 0; i < RegisteredEvents.size(); i++)
-            RegisteredEvents.remove(i);
+        RegisteredEvents.clear();
 
         foreach (auto inf in Interfaces)
         {

Tasking/Security.cpp

@@ -145,10 +145,5 @@ namespace Tasking
     }
 
     Security::Security() {}
-
-    Security::~Security()
-    {
-        for (size_t i = 0; i < Tokens.size(); i++)
-            Tokens.remove(i);
-    }
+    Security::~Security() { Tokens.clear(); }
 }